-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update iframe feature policy #1552
fix: update iframe feature policy #1552
Conversation
This is needed to fix Xblock video play button not working in Chrome for youtube videos due to iframe security policy.
Thanks for the pull request, @a-asad! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
@a-asad Thanks! Please get your CLA in place and let us know when this is ready for review. I'll have to ask the Security Working Group to take a look as they need to review any changes to this policy. |
I have submitted a request for the CLA and will update here when it's signed. |
@bradenmacdonald it's ready for review. |
@a-asad Sorry for the delay. @gabor-boros @feanil could you or others from the Security Working Group please review this PR, as required by the comment in the code? Not sure exactly who I should ping. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
=======================================
Coverage 89.82% 89.82%
=======================================
Files 326 326
Lines 5601 5601
Branches 1396 1396
=======================================
Hits 5031 5031
Misses 554 554
Partials 16 16 ☔ View full report in Codecov by Sentry. |
8890fb7
to
2cbfdf5
Compare
Thanks @bradenmacdonald! |
Description
It's a fix for this issue. It's needed to fix the Xblock video play button not working on Chrome for youtube videos due to the iframe security policy. Chrome blocks playing a youtube video programmatically when the iframe is not inside the parent window, which in our case is inside the Xblock iframe.
Testing Instructions
Now check out this PR.