Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update iframe feature policy #1552

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

a-asad
Copy link
Contributor

@a-asad a-asad commented Dec 11, 2024

Description

It's a fix for this issue. It's needed to fix the Xblock video play button not working on Chrome for youtube videos due to the iframe security policy. Chrome blocks playing a youtube video programmatically when the iframe is not inside the parent window, which in our case is inside the Xblock iframe.

Testing Instructions

  • Check out master/main
  • Add a YouTube video to a course unit
  • Preview the course in Chrome(or any Chromium-based browser)
  • Navigate to the respective video section and play the video using the video player's play button. The video will not play.

Now check out this PR.

  • Refresh the page and play the video again.
  • It should start playing this time.

This is needed to fix Xblock video play button not working in Chrome for youtube videos due to iframe security policy.
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 11, 2024
@openedx-webhooks
Copy link

openedx-webhooks commented Dec 11, 2024

Thanks for the pull request, @a-asad!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/committers-frontend-app-learning. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bradenmacdonald
Copy link
Contributor

bradenmacdonald commented Dec 11, 2024

@a-asad Thanks! Please get your CLA in place and let us know when this is ready for review. I'll have to ask the Security Working Group to take a look as they need to review any changes to this policy.

@itsjeyd itsjeyd added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Dec 12, 2024
@a-asad
Copy link
Contributor Author

a-asad commented Dec 12, 2024

I have submitted a request for the CLA and will update here when it's signed.

@a-asad
Copy link
Contributor Author

a-asad commented Dec 14, 2024

@bradenmacdonald it's ready for review.

@bradenmacdonald
Copy link
Contributor

@a-asad Sorry for the delay. @gabor-boros @feanil could you or others from the Security Working Group please review this PR, as required by the comment in the code? Not sure exactly who I should ping. Thanks!

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (8a6fa93) to head (8890fb7).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1552   +/-   ##
=======================================
  Coverage   89.82%   89.82%           
=======================================
  Files         326      326           
  Lines        5601     5601           
  Branches     1396     1396           
=======================================
  Hits         5031     5031           
  Misses        554      554           
  Partials       16       16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@a-asad a-asad force-pushed the a-asad/video-play-button-fix branch from 8890fb7 to 2cbfdf5 Compare December 17, 2024 20:51
@bradenmacdonald bradenmacdonald merged commit 4a80532 into openedx:master Dec 18, 2024
11 checks passed
@a-asad
Copy link
Contributor Author

a-asad commented Dec 18, 2024

Thanks @bradenmacdonald!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants